Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -i for stdin in snow sql #592

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Use -i for stdin in snow sql #592

merged 5 commits into from
Dec 11, 2023

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

-i has to be provided to use stdin as query input

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review December 8, 2023 14:38
@sfc-gh-cgorrie
Copy link
Contributor

@sfc-gh-turbaszek Many CLI tools treat stdin as the default when no input option is given, as is the current behaviour of the tool. What was the motivation for changing this behaviour?

@sfc-gh-turbaszek
Copy link
Contributor Author

@sfc-gh-turbaszek Many CLI tools treat stdin as the default when no input option is given, as is the current behaviour of the tool. What was the motivation for changing this behaviour?

  1. Being more explicit about the behaviour. 2. Leaving space for snow sql starting a SQL session (like snowsql).

@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) December 11, 2023 11:20
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 35e3ca5 into main Dec 11, 2023
14 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the stdin-sql branch December 11, 2023 11:22
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants