Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the tests with Snowplow Micro #144

Open
mscwilson opened this issue Oct 1, 2021 · 0 comments
Open

Improve the tests with Snowplow Micro #144

mscwilson opened this issue Oct 1, 2021 · 0 comments
Labels
type:enhancement New features or improvements to existing features.
Milestone

Comments

@mscwilson
Copy link
Contributor

The tests currently mock out the sending of events. A more thorough and realistic set of tests would be to use the testing pipeline Snowplow Micro. This has been done for the Snowplow React Native tracker.

Also, the structure of the current tests could be improved. There are not many unit tests, and the integration tests are all together in one long and confusing file. The spec_helper.rb file monkey-patches in some methods for the Emitter class, as well as two class variables. This means that the tests are not completely isolated from each other.

@mscwilson mscwilson added the type:enhancement New features or improvements to existing features. label Oct 1, 2021
@mscwilson mscwilson added this to the Version 1.0.0 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New features or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

1 participant