You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For npm: the aliased package is not tested, but its dependencies are correctly tested.
https://github.com/SyntraInc/public_demo/blob/main/snyk_npm_repro/package.json
...
"dependencies": {
"my_vulnerable_request": "npm:[email protected]"
},
...
$ snyk test
Tested 47 dependencies for known issues, found 1 issue, 1 vulnerable path.
Issues with no direct upgrade or patch:
✗ Prototype Pollution [Medium Severity][https://security.snyk.io/vuln/SNYK-JS-TOUGHCOOKIE-5672873] in [email protected]
introduced by [email protected] > [email protected]
This issue was fixed in versions: 4.1.3
For pnpm, I believe because of #248, the aliased package is tested, but for some reason, none of its dependencies are tested.
https://github.com/SyntraInc/public_demo/blob/main/snyk_pnpm_repro/package.json
"dependencies": {
"my_vulnerable_request": "npm:[email protected]"
},
$ snyk test
Testing /Users/utsavshah/p/vulns/public_demo/snyk_pnpm_repro...
Tested 1 dependencies for known issues, found 1 issue, 1 vulnerable path.
Issues with no direct upgrade or patch:
✗ Server-side Request Forgery (SSRF) [Medium Severity][https://security.snyk.io/vuln/SNYK-JS-REQUEST-3361831] in [email protected]
introduced by [email protected]
No upgrade or patch available
I think in both cases, the ideal behavior would be for both vulnerabilities - request and tough-cookie to be present.
I tested on the Snyk dashboard, and the results are the same as the CLI.
The text was updated successfully, but these errors were encountered:
It's trivially easy for users to alias packages and have them stop showing up in dependency scans.
Repro repo: https://github.com/SyntraInc/public_demo/tree/main
For
npm
: the aliased package is not tested, but its dependencies are correctly tested.For
pnpm
, I believe because of #248, the aliased package is tested, but for some reason, none of its dependencies are tested.I think in both cases, the ideal behavior would be for both vulnerabilities -
request
andtough-cookie
to be present.I tested on the Snyk dashboard, and the results are the same as the CLI.
The text was updated successfully, but these errors were encountered: