Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing objects from model instead full page reload #112

Open
wingsofovnia opened this issue May 12, 2017 · 0 comments
Open

Consider removing objects from model instead full page reload #112

wingsofovnia opened this issue May 12, 2017 · 0 comments

Comments

@wingsofovnia
Copy link
Member

Such requests:

$scope.deleteStation = function (name, location) {
    $http.delete(location).then(function () {
      $scope.loadPage($scope.currentPageIndex(), function () {
        $scope.addAlert('Station \'' + name + ' \' has been deleted!', 'success');
      });
    }, function (error) {
      $scope.addAlert('Error happened: \'' + error.data.message + ' \'', 'danger');
    });
  };

Reload the whole page that can be very heavyweight. Consider removing objects from angular model instead full page reload:

delete $scope.page.stations[index]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants