Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change names for ForwardPass #19

Open
alaksiej-stankievicx-dunnhumby opened this issue Sep 15, 2017 · 0 comments
Open

Change names for ForwardPass #19

alaksiej-stankievicx-dunnhumby opened this issue Sep 15, 2017 · 0 comments

Comments

@alaksiej-stankievicx-dunnhumby
Copy link

alaksiej-stankievicx-dunnhumby commented Sep 15, 2017

As @jens-mueller-sociomantic and I were discussing: the names of enum ForwardPass and its values should be renamed to express, what happens.

One possible variant is:

enum ForwardPassMode
{
    OutputOnly = false,
    Objective    = true
}

(last filed can be also Gradient, but it worse describe what really happens)

Also we should not provide any default value for forward pass, that reader of code could see what exactly happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant