You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that in_temporary_directory has some downsides:
It requires that tests not run in parallel. This isn't a problem now, but if the tests got more numerous or slower, it could be come one.
Tests that want to get or set the current directory need to use in_temporary_directory. If other tests didn't modify in_temporary_directory, then only those tests that needed to set the current dir would need to use something, which I think is the default expectation.
One nice thing about in_temporary_directory is that cmd! invocations are as close as possible to what users would be doing, and no extra mechanisms are in-use which might cause behavior to be different, or to cause unrelated tests to fail.
The text was updated successfully, but these errors were encountered:
I think that
in_temporary_directory
has some downsides:in_temporary_directory
. If other tests didn't modifyin_temporary_directory
, then only those tests that needed to set the current dir would need to use something, which I think is the default expectation.One nice thing about
in_temporary_directory
is thatcmd!
invocations are as close as possible to what users would be doing, and no extra mechanisms are in-use which might cause behavior to be different, or to cause unrelated tests to fail.The text was updated successfully, but these errors were encountered: