From a52d5b7d64b7c17b8a7fbc4a26acb9d7003aeafb Mon Sep 17 00:00:00 2001
From: liu-657627 <837397251@qq.com>
Date: Tue, 5 Sep 2023 08:34:03 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BF=AE=E6=94=B9=E5=8D=95=E6=B5=8B=E5=90=8D?=
 =?UTF-8?q?=E7=A7=B0?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../internal/utils/controller_utils_test.go   | 42 ++++++++++++-------
 1 file changed, 28 insertions(+), 14 deletions(-)

diff --git a/module-controller/internal/utils/controller_utils_test.go b/module-controller/internal/utils/controller_utils_test.go
index 6b4faa5ab..f5cd24645 100644
--- a/module-controller/internal/utils/controller_utils_test.go
+++ b/module-controller/internal/utils/controller_utils_test.go
@@ -1,6 +1,7 @@
 package utils
 
 import (
+	"github.com/sofastack/sofa-serverless/internal/constants/finalizer"
 	"github.com/stretchr/testify/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
@@ -9,27 +10,40 @@ import (
 	"time"
 )
 
-const (
-	ExistingModuleReplicaSetFinalizer = "existing-module-replicaset"
-)
+func TestAddNotExistedFinalizer(t *testing.T) {
+	meta := &metav1.ObjectMeta{}
+	assert.True(t, AddFinalizer(meta, finalizer.ModuleReplicaSetExistedFinalizer))
+}
+
+func TestHasNotExistedFinalizer(t *testing.T) {
+	meta := &metav1.ObjectMeta{}
+	assert.False(t, HasFinalizer(meta, finalizer.ModuleReplicaSetExistedFinalizer))
+}
+
+func TestRemoveNotExistedFinalizer(t *testing.T) {
+	meta := &metav1.ObjectMeta{}
+	assert.False(t, RemoveFinalizer(meta, finalizer.ModuleReplicaSetExistedFinalizer))
+}
+
+func TestAddExistedFinalizer(t *testing.T) {
+	meta := &metav1.ObjectMeta{}
+	meta.Finalizers = []string{finalizer.ModuleReplicaSetExistedFinalizer}
+	assert.False(t, AddFinalizer(meta, finalizer.ModuleReplicaSetExistedFinalizer))
+}
 
-func TestFinalizerFunTrue(t *testing.T) {
+func TestHasExistedFinalizer(t *testing.T) {
 	meta := &metav1.ObjectMeta{}
-	assert.True(t, AddFinalizer(meta, ExistingModuleReplicaSetFinalizer))
-	assert.True(t, HasFinalizer(meta, ExistingModuleReplicaSetFinalizer))
-	assert.True(t, RemoveFinalizer(meta, ExistingModuleReplicaSetFinalizer))
+	meta.Finalizers = []string{finalizer.ModuleReplicaSetExistedFinalizer}
+	assert.True(t, HasFinalizer(meta, finalizer.ModuleReplicaSetExistedFinalizer))
 }
 
-func TestFinalizerFunFalse(t *testing.T) {
+func TestRemoveExistedFinalizer(t *testing.T) {
 	meta := &metav1.ObjectMeta{}
-	meta.Finalizers = []string{ExistingModuleReplicaSetFinalizer}
-	assert.False(t, AddFinalizer(meta, ExistingModuleReplicaSetFinalizer))
-	assert.False(t, RemoveFinalizer(meta, "test"))
-	RemoveFinalizer(meta, ExistingModuleReplicaSetFinalizer)
-	assert.False(t, HasFinalizer(meta, ExistingModuleReplicaSetFinalizer))
+	meta.Finalizers = []string{finalizer.ModuleReplicaSetExistedFinalizer}
+	assert.True(t, RemoveFinalizer(meta, finalizer.ModuleReplicaSetExistedFinalizer))
 }
 
-func TestKeyFun(t *testing.T) {
+func TestKeyEqual(t *testing.T) {
 	request := ctrl.Request{NamespacedName: types.NamespacedName{Namespace: "default", Name: "test"}}
 	key := Key(request)
 	assert.Equal(t, "default/test", key)