This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
<feat> add base build plugin to promote the priority of sofaserverles… #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
============================================
+ Coverage 81.57% 81.67% +0.09%
- Complexity 65 66 +1
============================================
Files 41 41
Lines 1015 1015
Branches 90 90
============================================
+ Hits 828 829 +1
Misses 135 135
+ Partials 52 51 -1 ☔ View full report in Codecov by Sentry. |
|
lvjing2
reviewed
Dec 29, 2023
| LOGGER.info("Spring Boot Version: " + SpringApplication.class.getPackage().getImplementationVersion()); | ||
| LOGGER.info("BaseApplication classLoader: " + BaseApplication.class.getClassLoader()); | ||
| } | ||
| public static void main(String[] args) { |
lvjing2
reviewed
Dec 29, 2023
| @@ -76,6 +76,7 @@ | |||
| </scm> | |||
|
|
|||
| <modules> | |||
| <module>sofa-serverless-base-package-maven-plugin</module> | |||
There was a problem hiding this comment.
可以改成这个名字：
sofa-serverless-base-maven-plugin
lvjing2
reviewed
Dec 29, 2023
| <groupId>org.alipay.sofa.serverless</groupId> | ||
| <artifactId>sofa-serverless-base-package-maven-plugin</artifactId> | ||
| <packaging>maven-plugin</packaging> | ||
| <version>0.0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
版本号和 sofa serverless runtime 保持一直
lvjing2
reviewed
Dec 29, 2023
| </plugin> | ||
| <plugin> | ||
| <groupId>org.example</groupId> | ||
| <artifactId>sofa-serverless-base-build</artifactId> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sofaservelress 需要在基座上打一些补丁以和中间件兼容，确保单 JVM 多应用的模式下不出问题。
该构建插件保证 sofasreverless 打补丁的同名类会被优先加载。
Motivation
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification
Describe the idea and modifications you've done.
Result
Resolved or fixed #398
If there is no issue then describe the changes introduced by this PR.