This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Increase the usage of MetaSpace in computing #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glmapper
suggested changes
Sep 19, 2023
...-core/src/main/java/com/alipay/sofa/serverless/arklet/core/command/record/ProcessRecord.java
Outdated
Show resolved
Hide resolved
|
麻烦 @sususama 单测补充下，另外 @yuanyuan2021 补充下文档到 docs 目录里。我们新feature 上线前需要确保单测和文档更新后再合并。 |
yuanyuancin
reviewed
Sep 20, 2023
| @@ -58,10 +59,17 @@ public static List<ProcessRecord> getProcessRecordsByStatus(String status) { | |||
|
|
|||
| public static ProcessRecord createProcessRecord(String rid, ArkBizMeta arkBizMeta) { | |||
| ProcessRecord pr = new ProcessRecord(); | |||
There was a problem hiding this comment.
ProcessRecord只有在async时才有
| pr.setRequestId(rid); | ||
| pr.setArkBizMeta(arkBizMeta); | ||
| pr.setStatus(INITIALIZED); | ||
| Date date = new Date(); | ||
| pr.setMetaSpaceMXBean(metaSpaceMXBean); |
There was a problem hiding this comment.
可以使用static缓存metaSpaceMXBean，不要放在成员变量里
There was a problem hiding this comment.
我在这里将metaSpaceMXBean放进成员变量里是因为后面在ProcessRecord里面需要再次用到metaSpaceMXBean，如果不放的话可以每次用的时候都在memoryPoolMXBeans里面重新遍历出来metaSpaceMXBean
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification
Describe the idea and modifications you've done.
Result
Increase the usage of MetaSpace in computing
Resolved or fixed #77
If there is no issue then describe the changes introduced by this PR.