Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider modification of file stream during Broccoli build rather than insertIntoFile() calls #4

Open
notmessenger opened this issue Nov 25, 2014 · 4 comments

Comments

@notmessenger
Copy link
Collaborator

Research modifying the Broccoli file stream rather than making actual physical changes to the files as currently doing in the blueprint. This will make it easier to swap test libraries in the future.

Since is "just" testing code the change can be applied on the fly and not have to be captured in source control. The source control change will be the inclusion of the addon in package.json

That's my current thinking anyways. Need to spend some more time with the idea

@notmessenger
Copy link
Collaborator Author

If modify the stream versus the on-disk file though it will be harder for the user to know when the add on was not able to successfully inject itself in the correct location in the files. This add on could keep up with Ember CLI version upgrades and the structures of the files but if a user has made enough changes to their application's copy of these files then the required injections will not occur properly. Would need to find a way to address this if using this approach.

@notmessenger
Copy link
Collaborator Author

Will likely be addressed by #159

@notmessenger
Copy link
Collaborator Author

Is this of any inspiration? ember-cli/ember-cli#2748

notmessenger pushed a commit that referenced this issue Jan 30, 2016
@notmessenger
Copy link
Collaborator Author

This should be done via blueprints instead of the need to write to files in this manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant