feat(sdk): add proper toString methods for GameResult & its dependencies

# Conflicts:
#	server/src/sc/server/Lobby.kt
#	server/src/sc/server/network/ClientManager.java
#	server/src/sc/server/network/NewClientListener.java

Author: xeruf

socha-sdk/src/framework/sc/shared/GameResult.kt

@@ -18,13 +18,7 @@ data class GameResult(
         get() = scores.all { it.cause == ScoreCause.REGULAR }
 
     override fun toString(): String {
-        val builder = StringBuilder("Winner: ").append(winners)
-        scores.forEachIndexed { playerIndex, score ->
-            builder.appendln().append("Player ").append(playerIndex).append(": ")
-            val scoreParts = score.toStrings()
-            builder.append(scoreParts.indices.joinToString("; ") { i -> "${definition[i].name}=${scoreParts[i]}" })
-        }
-        return builder.toString()
+        return "GameResult(winner=$winners, scores=[${(0..scores.lastIndex).joinToString { i -> "Player${i+1}${scores[i].toString(definition).removePrefix("PlayerScore")}" }}])"
     }
 
 }

socha-sdk/src/framework/sc/shared/PlayerScore.kt

@@ -3,6 +3,7 @@ package sc.shared
 import com.thoughtworks.xstream.annotations.XStreamAlias
 import com.thoughtworks.xstream.annotations.XStreamAsAttribute
 import com.thoughtworks.xstream.annotations.XStreamImplicit
+import java.lang.IllegalArgumentException
 import java.math.BigDecimal
 
 @XStreamAlias(value = "score")
@@ -20,9 +21,6 @@ data class PlayerScore(
 
     fun size(): Int = parts.size
 
-    fun toStrings(): Array<String> =
-            parts.map { it.toString() }.toTypedArray()
-    
     val values: List<BigDecimal>
         get() = parts.asList()
 
@@ -42,6 +40,12 @@ data class PlayerScore(
         return result
     }
 
+    fun toString(definition: ScoreDefinition): String {
+        if(!matches(definition))
+            throw IllegalArgumentException("$definition does not match $this")
+        return "PlayerScore(cause=$cause, reason='$reason', parts=[${(0..parts.lastIndex).joinToString { i -> "${definition.get(i).name}=${parts[i]}" }}])"
+    }
+    
     override fun toString(): String {
         return "PlayerScore(cause=$cause, reason='$reason', parts=${parts.contentToString()})"
     }

socha-sdk/src/framework/sc/shared/ScoreDefinition.java

@@ -37,6 +37,11 @@ public Iterator<ScoreFragment> iterator() {
     return this.fragments.iterator();
   }
 
+  @Override
+  public String toString() {
+    return "ScoreDefinition(fragments=" + fragments + ')';
+  }
+
   @Override
   public boolean equals(Object o) {
     if (o instanceof ScoreDefinition) {