-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work in monorepo codebases #821
Comments
Hi, thanks for reporting. Could you provide more details about your setup? You should be able to run it from the workspace root (in case of multiple apps, one of them will be chosen, unless configured with appRoot in launch.json). |
So I was able to launch via Radon IDE: Diagnostics but that's it no other options seem to work for me |
Thanks @jcgertig for this report. Would you be able to share some sample repo with similar structure and configuration that we could use to reproduce this issue? |
Fixes #821 Currently, we look for different files in the root of the workspace to recognize if VSCode should activate the extension, this doesn't work in monorepo, as those files might be deeper in the file tree. This pr adds `**/` before each pattern to fix that. ### How Has This Been Tested: - Open nx-monorepo - Confirm the "Open IDE Panel" is visible - Repeat for any other repo
Thanks @maciekstosio and @kmagiera for the help |
@kmagiera any idea when this will be ready? |
@jcgertig we plan to publish an update next week that'd include this and other changes. If you'd like I can build a .vsix file for you to install and try locally before then. |
That could be helpful unfortunately the above #830 has bricked to extension for me currently |
Description
The activation settings make it so that this does not work in a monorepo
If it was a glob workspaceContains:**/metro.config.ts would work or better yet config setting to choose
Environment
The text was updated successfully, but these errors were encountered: