Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in monorepo codebases #821

Closed
jcgertig opened this issue Dec 3, 2024 · 8 comments · Fixed by #823
Closed

Does not work in monorepo codebases #821

jcgertig opened this issue Dec 3, 2024 · 8 comments · Fixed by #823
Labels
bug Something isn't working

Comments

@jcgertig
Copy link

jcgertig commented Dec 3, 2024

Description
The activation settings make it so that this does not work in a monorepo
If it was a glob workspaceContains:**/metro.config.ts would work or better yet config setting to choose

Environment

  • Version of currently used Radon IDE (Extensions tab -> click on Radon IDE extension -> version is located next to the extension name) 1.0.0
@jcgertig jcgertig added the bug Something isn't working label Dec 3, 2024
@maciekstosio
Copy link
Contributor

Hi, thanks for reporting. Could you provide more details about your setup? You should be able to run it from the workspace root (in case of multiple apps, one of them will be chosen, unless configured with appRoot in launch.json).

@jcgertig
Copy link
Author

jcgertig commented Dec 3, 2024

Screenshot 2024-12-03 at 11 06 35 AM Screenshot 2024-12-03 at 11 05 01 AM

@jcgertig
Copy link
Author

jcgertig commented Dec 3, 2024

So I was able to launch via Radon IDE: Diagnostics but that's it no other options seem to work for me

@kmagiera
Copy link
Member

kmagiera commented Dec 3, 2024

Thanks @jcgertig for this report. Would you be able to share some sample repo with similar structure and configuration that we could use to reproduce this issue?

maciekstosio added a commit that referenced this issue Dec 4, 2024
Fixes #821

Currently, we look for different files in the root of the workspace to
recognize if VSCode should activate the extension, this doesn't work in
monorepo, as those files might be deeper in the file tree. This pr adds
`**/` before each pattern to fix that.

### How Has This Been Tested: 

- Open nx-monorepo 
- Confirm the "Open IDE Panel" is visible 
- Repeat for any other repo
@jcgertig
Copy link
Author

jcgertig commented Dec 4, 2024

Thanks @maciekstosio and @kmagiera for the help

@jcgertig
Copy link
Author

jcgertig commented Dec 4, 2024

@kmagiera any idea when this will be ready?

@kmagiera
Copy link
Member

kmagiera commented Dec 4, 2024

@jcgertig we plan to publish an update next week that'd include this and other changes. If you'd like I can build a .vsix file for you to install and try locally before then.

@jcgertig
Copy link
Author

jcgertig commented Dec 4, 2024

That could be helpful unfortunately the above #830 has bricked to extension for me currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants