Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux support for VSCode extension (#688) #829

Merged

Conversation

tobisamuel
Copy link
Contributor

@tobisamuel tobisamuel commented Dec 4, 2024

This PR adds Linux support to the VSCode extension, implementing platform-specific paths and configurations. The changes follow patterns established in PR #462 (Windows support) and make the extension functional on Linux systems.

  • Add Linux as a supported platform in Platform module
  • Implement Linux paths for Android SDK and tooling
  • Add Linux-specific configurations for file system and processes
  • Update UI components to handle Linux keyboard shortcuts

Fixes #688

How This Has Been Tested

To ensure the changes in this PR work as expected, the following test plan was carried out:

  • Run development version of the extension successfully on my Linux Mint (based on Ubuntu 24.04) machine.
  • Ensure the ANDROID_HOME
    environment variable was correctly set on my system
  • A React Native project was initialized, and the extension managed the building and installing the app on the selected emulator.
  • Verified that all extension features, such as the inspector, debugger, device settings, and screen recording worked correctly on Linux.
output.mp4

- Add Linux as a supported platform in Platform module
- Implement Linux paths for Android SDK and tooling
- Add Linux-specific configurations for file system and processes
- Update UI components to handle Linux keyboard shortcuts
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 0:07am

Copy link
Contributor

@maciekstosio maciekstosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! One initial nitpick. We need to test it, but it looks good at first sight.

packages/vscode-extension/src/extension.ts Outdated Show resolved Hide resolved
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tobisamuel for working on this.

The code looks good, however, I'd like if you could update the PR description with test plan. Specifically we want to know what and how you tested things. This way in the future we could tell at which point things broke or whether things just weren't tested. Would be the best if you could upload some screen recording showcasing the tool in action on Linux too.

Thank you!

@tobisamuel
Copy link
Contributor Author

tobisamuel commented Dec 6, 2024

Hi @kmagiera,

Thanks for the feedback! I have updated the PR description to include a test plan. I have also attached a screen recording to show the extension in action on Linux.

Please let me know if there's anything else you'd like me to address!

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect now, thank you!

@kmagiera
Copy link
Member

kmagiera commented Dec 6, 2024

@tobisamuel – looks like lint is failing due to code formatting issue. You should be able to resolve this by running npm run format in the main project directory

@tobisamuel
Copy link
Contributor Author

Fixed the formatting issues @kmagiera. The lint checks should now pass.

@kmagiera kmagiera merged commit 33c0c4c into software-mansion:main Dec 9, 2024
4 checks passed
@tobisamuel tobisamuel deleted the @tobisamuel/add-linux-support branch December 16, 2024 13:06
kmagiera pushed a commit that referenced this pull request Feb 12, 2025
Since we've added a support of Radon IDE for Linux
(#829), it's time to
change its support in compatibility table 😄
This PR changes the value of compatibility for Linux, indicating that
this system is officially supported from now on.

### How Has This Been Tested: 

Manually, by building the `docs` package and running it in development
mode with `yarn start`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux support
3 participants