-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux support for VSCode extension (#688) #829
Add Linux support for VSCode extension (#688) #829
Conversation
- Add Linux as a supported platform in Platform module - Implement Linux paths for Android SDK and tooling - Add Linux-specific configurations for file system and processes - Update UI components to handle Linux keyboard shortcuts
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! One initial nitpick. We need to test it, but it looks good at first sight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tobisamuel for working on this.
The code looks good, however, I'd like if you could update the PR description with test plan. Specifically we want to know what and how you tested things. This way in the future we could tell at which point things broke or whether things just weren't tested. Would be the best if you could upload some screen recording showcasing the tool in action on Linux too.
Thank you!
Co-authored-by: Maciej Stosio <[email protected]>
Hi @kmagiera, Thanks for the feedback! I have updated the PR description to include a test plan. I have also attached a screen recording to show the extension in action on Linux. Please let me know if there's anything else you'd like me to address! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect now, thank you!
@tobisamuel – looks like lint is failing due to code formatting issue. You should be able to resolve this by running |
Fixed the formatting issues @kmagiera. The lint checks should now pass. |
Since we've added a support of Radon IDE for Linux (#829), it's time to change its support in compatibility table 😄 This PR changes the value of compatibility for Linux, indicating that this system is officially supported from now on. ### How Has This Been Tested: Manually, by building the `docs` package and running it in development mode with `yarn start`.
This PR adds Linux support to the VSCode extension, implementing platform-specific paths and configurations. The changes follow patterns established in PR #462 (Windows support) and make the extension functional on Linux systems.
Fixes #688
How This Has Been Tested
To ensure the changes in this PR work as expected, the following test plan was carried out:
environment variable was correctly set on my system
output.mp4