Make Fabric event receivers init only once #6907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6896
When adding support for fabric, we have inadvertently kept previous listeners still active for fabric. This way, we registered twice with the same
NodesManager
for React Native'sFabricEventDispatcher
, resulting in pretty much all the events doubling in number on android. I added a simple check that takes care of it.Test plan
Paste the following into
EmptyExample
and runFabricExample
. Check logs making sure that bothstart
andend
are logged only once per gesture.