Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review snippets for conflicts with autocomplete features #39

Closed
mkaput opened this issue Dec 18, 2024 · 0 comments · Fixed by #59
Closed

Review snippets for conflicts with autocomplete features #39

mkaput opened this issue Dec 18, 2024 · 0 comments · Fixed by #59
Assignees

Comments

@mkaput
Copy link
Member

mkaput commented Dec 18, 2024

@mkaput commented on 5.12.2024, 14:25:45:

Bad snippets are worse then a lack of it.

For example, when you type use stark you'll get suggestion to insert the starknet snippet which is bad.

@mkaput mkaput added this to CairoLS Dec 18, 2024
@github-project-automation github-project-automation bot moved this to Triage in CairoLS Dec 18, 2024
@mkaput mkaput moved this from Triage to Backlog in CairoLS Dec 18, 2024
@Arcticae Arcticae moved this from Backlog to Todo in CairoLS Jan 15, 2025
@Arcticae Arcticae marked this as a duplicate of software-mansion/cairols#183 Jan 15, 2025
@Arcticae Arcticae marked this as a duplicate of software-mansion/cairols#182 Jan 15, 2025
Draggu added a commit that referenced this issue Jan 15, 2025
Closes #39

Following the rule that
> Bad snippets are worse then a lack of it.

Snippets from these groups are removed
- Starknet - users mostly uses templates/llm for theses
- Macros - We will replace them with autocompletion anyway
- `const` - not so usefull, it only adds 2 chars while user have to write rest anyway

Edited
- `fn`, `match`, `enum` - to make these more general
- `trait`, `impl` - to align them with current syntax and make more general

commit-id:7b1d01bc
Draggu added a commit that referenced this issue Jan 15, 2025
Closes #39

Following the rule that
> Bad snippets are worse then a lack of it.

Snippets from these groups are removed
- Starknet - users mostly uses templates/llm for these
- Macros - We will replace them with autocompletion anyway
- `const` - not so usefull, it only adds 2 chars while user have to write rest anyway

Edited
- `fn`, `match`, `enum` - to make these more general
- `trait`, `impl` - to align them with current syntax and make more general

commit-id:7b1d01bc
Draggu added a commit that referenced this issue Jan 15, 2025
Closes #39

Following the rule that
> Bad snippets are worse then a lack of it.

Snippets from these groups are removed
- Starknet - users mostly uses templates/llm for these
- Macros - We will replace them with autocompletion anyway
- `const` - not so usefull, it only adds 2 chars while user have to write rest anyway

Edited
- `fn`, `match`, `enum` - to make these more general
- `trait`, `impl` - to align them with current syntax and make more general

commit-id:7b1d01bc
@github-project-automation github-project-automation bot moved this from Todo to Done in CairoLS Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants