Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to upstream CFF-Convert #197

Closed
led02 opened this issue Jul 11, 2023 · 2 comments · Fixed by #199
Closed

Switch back to upstream CFF-Convert #197

led02 opened this issue Jul 11, 2023 · 2 comments · Fixed by #199
Labels
1️ harvesting The harvesting step in the workflow 2️ process/validate The processing/validation step in the workflow enhancement New feature or request good first issue Good for newcomers
Milestone
Proof-of-concept

Comments

@led02
Copy link
Member

led02 commented Jul 11, 2023

They merged our changes (and some additional stuff). Hence, we should switch back to the "upstream" version even though the branch is still available (but for how long?)

citation-file-format/cffconvert#309
@led02 led02 added enhancement New feature or request good first issue Good for newcomers 1️ harvesting The harvesting step in the workflow 2️ process/validate The processing/validation step in the workflow labels Jul 11, 2023
@led02 led02 added this to the Proof-of-concept milestone Jul 11, 2023
@led02
Copy link
Member Author

led02 commented Aug 2, 2023

No new release available yet, hence we still install from repo. But this time from default branch!

@led02 led02 linked a pull request Aug 2, 2023 that will close this issue
Remove our specific branch from installation of cffconvert. #199
Merged
@led02
Copy link
Member Author

led02 commented Aug 3, 2023

  1. Our test cases do not comply to RFC 6761
  2. The "fixed" version of CFFConvert makes "Organizations" from our "Authors" (I think due to them having a name but no first/lastName.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1️ harvesting The harvesting step in the workflow 2️ process/validate The processing/validation step in the workflow enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Proof-of-concept
Development

Successfully merging a pull request may close this issue.

Remove our specific branch from installation of cffconvert. softwarepub/hermes
1 participant
@led02