Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small error when calling function cimexport #25

Closed
martinmoraga opened this issue Oct 19, 2023 · 3 comments
Closed

Small error when calling function cimexport #25

martinmoraga opened this issue Oct 19, 2023 · 3 comments
Assignees
@stv0g @martinmoraga
Labels
bug Something isn't working

Comments

@martinmoraga
Copy link
Contributor

martinmoraga commented Oct 19, 2023 •
edited
Loading

Sometimes when using the funcion cimexport a KeyError Exception occurs
@martinmoraga martinmoraga added the bug Something isn't working label Oct 19, 2023
@martinmoraga martinmoraga self-assigned this Oct 19, 2023
@martinmoraga martinmoraga linked a pull request Oct 19, 2023 that will close this issue
Fix small error in cimexport.py #26
Closed
@martinmoraga martinmoraga mentioned this issue Oct 19, 2023
Closed
@github-project-automation github-project-automation bot moved this to Done in DPsim Oct 19, 2023
@martinmoraga martinmoraga mentioned this issue Oct 26, 2023
Open
@stv0g
Copy link
Collaborator

stv0g commented Jun 17, 2024

Hi @martinmoraga,

I am wondering, why is this issue closed when the associated PR has not been merged yet? Or are the two unrelated?

@martinmoraga
Copy link
Contributor Author

martinmoraga commented Jun 21, 2024 •
edited
Loading

Hi @martinmoraga,

I am wondering, why is this issue closed when the associated PR has not been merged yet? Or are the two unrelated?

Hi @stv0g

To be honest I dont know why this PR is closed... Now it is open again ;)

@martinmoraga martinmoraga reopened this Jun 21, 2024
@tom-hg57 tom-hg57 mentioned this issue Oct 3, 2024
Merged
m-mirz added a commit that referenced this issue Oct 30, 2024
@m-mirz
Add generation of CGMES profile class (#39)
0b78484 
Depends on cimgen pull request:
sogno-platform/cimgen#35, which is already
merged now.

In my repo all workflows run successfully:
tom-hg57#1 (even deploying of
github-pages).

Improve cimexport.py using profile URIs (from new generated
CGMESProfile.py) in model description of exported cim files
- Update generated python files created by cimgen
- Use profile URIs (from new generated CGMESProfile.py) in model
description of exported cim files
- Fix "Package information not found" for EquipmentBoundary and
ToplogyBoundary in cim_import() by using new generated CGMESProfile.py
- Fix export for data read without profile information
- Improve cim_export (activeProfileList is now optional - no
activeProfileList means output to all profile files with data)
- Add function cim_export_to_string_array
- Fix model ID in cim_export (must be unique across all files)
- Use recommended class profile from new generated classes (if data is
read without profile information, or some objects are added after
import)
- Improve .github/workflows/test.yaml
- Update documentation in cimpy/cimexport.py

With the new generated python files created by cimgen the issue
#23 is solved. PR
#24 could be closed if this
PR is merged.

The same applies to issue
#25 and PR
#26.
@m-mirz
Copy link
Contributor

m-mirz commented Oct 30, 2024

Solved in #39

@m-mirz m-mirz closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stv0g stv0g

@martinmoraga martinmoraga

Labels
bug Something isn't working
Projects
DPsim
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix small error in cimexport.py sogno-platform/cimpy
3 participants
@stv0g @m-mirz @martinmoraga