Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS global setting doesn't work #1

Open
joel-wright opened this issue Jan 20, 2015 · 0 comments
Open

CORS global setting doesn't work #1

joel-wright opened this issue Jan 20, 2015 · 0 comments
Labels
bug

Comments

@joel-wright
Copy link

garbled description from the top of my head - to be improved later

Unless the CORS accept header is set on a container CORS will not work. Just setting the global setting to accept does not work because the code path tries to call a string operation on None resulting in a 500 server error.
mmcardle pushed a commit that referenced this issue May 17, 2018
Refactor expirer unit tests
5cac372 
In expirer's unit tests, fake InternalClient classes are defined
and its instance simulates expirer's task queue behaviors.

To make review for expirer's task queue update patch [1] easy,
this patch refactors the implementation of the fake InternalClient
classes. In this patch, unit tests are refactored by the following
two approaches:
    #1: Summarizing duplicated fake InternalClient implementation
    #2: Make task account name variable
The #2 approach is for multiple task accounts in [1].

The patch [1] will be rebased after this patch merged.

[1]: https://review.openstack.org/#/c/517389

Change-Id: I10a7151cfdd43460ad38c47f672d3c31b77e7990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joel-wright