Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Firefox? #116

Open
gc-alexlong opened this issue Aug 25, 2016 · 4 comments
Open

Support for Firefox? #116

gc-alexlong opened this issue Aug 25, 2016 · 4 comments

Comments

@gc-alexlong
Copy link

I notice that Firefox will handle JavaScript errors differently than Chrome sometimes. I was wondering if adding support for Firefox as a browser debugging option would be possible. I tried opening Firefox, enabling remote debugging in its developer settings, then listened on port 9222. Then in Sublime Text, I run command for Web Inspector. Firefox prompts me to allow the connection, but that's as far as I get. After clicking "ok", Web Inspector doesn't recognize/connect to Firefox. I would like it if Web Inspector could also work with Firefox.

@danmoseley
Copy link
Collaborator

If Firefox supports the protocol, it could likely be done. We already have a similar issue for Edge: #93.

From experience (working on the Visual Studio tools that speak the Chrome protocol), all the protocol providers have their own little quirks. Even between versions of the same browser. So it would need a little debugging and tweaking of the code.

Interested in giving it a shot? I'd take PR's.

@gc-alexlong
Copy link
Author

I tried researching it but feel a bit over my head. I'll continue reading up on it.

@danmoseley
Copy link
Collaborator

danmoseley commented Aug 29, 2016

The essence of the work would be

  1. Hook up a debugger (the Visual Studio Python debugger seems to be the best -- I put instructions in Unable to move the cache, Unable to create cache #113 -- and set debug mode and/or web socket tracing
  2. Attempt to connect, look for obvious issues such as garbage response, exceptions thrown, etc
  3. Make a change to SWI to accommodate Firefox without breaking Chrome eg handle the different message parameter. This may need
    a) Do the same against Chrome and compare the traffic, or
    b) Trace Firefox running against itself, which clearly works, and compare the traffic
  4. Repeat
  5. Before finishing, make sure Chrome still works.

@danmoseley
Copy link
Collaborator

If you do this, you've added a major feature that a lot of people would find interesting, and most of the work is in the setup, figuring out how to trace etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants