Fix: all the biome errors and update biome (#86)

solana-developers · Jun 13, 2024 · 2c4cb8f · 2c4cb8f
1 parent dc25914
commit 2c4cb8f
Show file tree

Hide file tree

Showing 28 changed files with 265 additions and 266 deletions.
diff --git a/basics/account-data/native/tests/test.ts b/basics/account-data/native/tests/test.ts
@@ -6,9 +6,9 @@ import { start } from 'solana-bankrun';
 
 class Assignable {
   constructor(properties) {
-    Object.keys(properties).map((key) => {
-      return (this[key] = properties[key]);
-    });
+    for (const [key, value] of Object.entries(properties)) {
+      this[key] = value;
+    }
   }
 }
 

diff --git a/basics/counter/native/ts/instructions/createIncrementInstruction.ts b/basics/counter/native/ts/instructions/createIncrementInstruction.ts
@@ -4,9 +4,8 @@ import { PROGRAM_ID } from '../';
 export type IncrementInstructionAccounts = {
   counter: PublicKey;
 };
-export type IncrementInstructionArgs = {};
 
-export function createIncrementInstruction(accounts: IncrementInstructionAccounts, args: IncrementInstructionArgs): TransactionInstruction {
+export function createIncrementInstruction(accounts: IncrementInstructionAccounts): TransactionInstruction {
   return new TransactionInstruction({
     programId: PROGRAM_ID,
     keys: [

diff --git a/basics/create-account/anchor/tests/test.ts b/basics/create-account/anchor/tests/test.ts
@@ -28,7 +28,6 @@ describe('Create a system account', () => {
 
     // Check that the account was created
     const accountInfo = await connection.getAccountInfo(newKeypair.publicKey);
-    assert((accountInfo.owner = SystemProgram.programId));
     assert(accountInfo.lamports === lamports);
   });
 });
diff --git a/basics/cross-program-invocation/native/tests/test.ts b/basics/cross-program-invocation/native/tests/test.ts
@@ -14,9 +14,9 @@ describe('CPI Example', () => {
 
   class Assignable {
     constructor(properties) {
-      Object.keys(properties).map((key) => {
-        return (this[key] = properties[key]);
-      });
+      for (const [key, value] of Object.entries(properties)) {
+        this[key] = value;
+      }
     }
   }
 

diff --git a/basics/pda-rent-payer/native/tests/test.ts b/basics/pda-rent-payer/native/tests/test.ts
@@ -12,9 +12,9 @@ describe('PDA Rent-Payer', async () => {
 
   class Assignable {
     constructor(properties) {
-      Object.keys(properties).map((key) => {
-        return (this[key] = properties[key]);
-      });
+      for (const [key, value] of Object.entries(properties)) {
+        this[key] = value;
+      }
     }
   }
 

diff --git a/basics/processing-instructions/native/tests/test.ts b/basics/processing-instructions/native/tests/test.ts
@@ -12,9 +12,9 @@ describe('custom-instruction-data', async () => {
 
   class Assignable {
     constructor(properties) {
-      Object.keys(properties).map((key) => {
-        return (this[key] = properties[key]);
-      });
+      for (const [key, value] of Object.entries(properties)) {
+        this[key] = value;
+      }
     }
   }
 

diff --git a/basics/program-derived-addresses/native/tests/test.ts b/basics/program-derived-addresses/native/tests/test.ts
@@ -13,9 +13,9 @@ describe('PDAs', async () => {
 
   class Assignable {
     constructor(properties) {
-      Object.keys(properties).map((key) => {
-        return (this[key] = properties[key]);
-      });
+      for (const [key, value] of Object.entries(properties)) {
+        this[key] = value;
+      }
     }
   }
 

diff --git a/basics/rent/native/tests/test.ts b/basics/rent/native/tests/test.ts
@@ -12,9 +12,9 @@ describe('Create a system account', async () => {
 
   class Assignable {
     constructor(properties) {
-      Object.keys(properties).map((key) => {
-        return (this[key] = properties[key]);
-      });
+      for (const [key, value] of Object.entries(properties)) {
+        this[key] = value;
+      }
     }
   }
 

diff --git a/basics/repository-layout/native/tests/test.ts b/basics/repository-layout/native/tests/test.ts
@@ -12,9 +12,9 @@ describe('Carnival', async () => {
 
   class Assignable {
     constructor(properties) {
-      Object.keys(properties).map((key) => {
-        return (this[key] = properties[key]);
-      });
+      for (const [key, value] of Object.entries(properties)) {
+        this[key] = value;
+      }
     }
   }
 

diff --git a/biome.json b/biome.json
@@ -35,7 +35,7 @@
     "formatter": {
       "jsxQuoteStyle": "double",
       "quoteProperties": "asNeeded",
-      "trailingComma": "all",
+      "trailingCommas": "all",
       "semicolons": "always",
       "arrowParentheses": "always",
       "bracketSpacing": true,

diff --git a/compression/cnft-burn/anchor/tests/cnft-burn.ts b/compression/cnft-burn/anchor/tests/cnft-burn.ts
@@ -9,7 +9,7 @@ import { getAsset, getAssetProof } from './readApi';
 import { decode, mapProof } from './utils';
 
 // Replace this with your custom RPC endpoint that supports cNFT indexing
-export const RPC_PATH = 'https://api.devnet.solana.com';
+const RPC_PATH = 'https://api.devnet.solana.com';
 
 describe('cnft-burn', () => {
   // Configure the client to use the local cluster.

diff --git a/compression/cnft-burn/anchor/tests/utils/helpers.ts b/compression/cnft-burn/anchor/tests/utils/helpers.ts
@@ -9,6 +9,7 @@ const DEFAULT_DEMO_DATA_FILE = 'demo.json';
 
 /*
   Load locally stored PublicKey addresses
+  TODO: use the helpers library and delete this function
 */
 export function loadPublicKeysFromFile(absPath = `${DEFAULT_KEY_DIR_NAME}/${DEFAULT_PUBLIC_KEY_FILE}`) {
   try {
@@ -25,7 +26,7 @@ export function loadPublicKeysFromFile(absPath = `${DEFAULT_KEY_DIR_NAME}/${DEFA
 
     return data;
   } catch (err) {
-    // console.warn("Unable to load local file");
+    console.warn('Unable to load local file');
   }
   // always return an object
   return {};
@@ -51,7 +52,7 @@ export function saveDemoDataToFile(name: string, newData: any, absPath = `${DEFA
     return data;
   } catch (err) {
     console.warn('Unable to save to file');
-    // console.warn(err);
+    console.warn(err);
   }
 
   // always return an object
@@ -105,16 +106,17 @@ export function loadKeypairFromFile(absPath: string) {
     const keypair = Keypair.fromSecretKey(new Uint8Array(keyfileBytes));
     return keypair;
   } catch (err) {
-    // return false;
+    console.error('loadKeypairFromFile:', err);
     throw err;
   }
 }
 
 /*
   Save a locally stored JSON keypair file for later importing
+  TODO: delete this function and use the helpers library
 */
-export function saveKeypairToFile(keypair: Keypair, fileName: string, dirName: string = DEFAULT_KEY_DIR_NAME) {
-  fileName = path.join(dirName, `${fileName}.json`);
+export function saveKeypairToFile(keypair: Keypair, relativeFileName: string, dirName: string = DEFAULT_KEY_DIR_NAME) {
+  const fileName = path.join(dirName, `${relativeFileName}.json`);
 
   // create the `dirName` directory, if it does not exists
   if (!fs.existsSync(`./${dirName}/`)) fs.mkdirSync(`./${dirName}/`);

diff --git a/compression/cutils/anchor/tests/utils/helpers.ts b/compression/cutils/anchor/tests/utils/helpers.ts
@@ -105,16 +105,17 @@ export function loadKeypairFromFile(absPath: string) {
     const keypair = Keypair.fromSecretKey(new Uint8Array(keyfileBytes));
     return keypair;
   } catch (err) {
-    // return false;
+    console.error('loadKeypairFromFile:', err);
     throw err;
   }
 }
 
 /*
   Save a locally stored JSON keypair file for later importing
+  TODO: delete this function and use the helpers library
 */
-export function saveKeypairToFile(keypair: Keypair, fileName: string, dirName: string = DEFAULT_KEY_DIR_NAME) {
-  fileName = path.join(dirName, `${fileName}.json`);
+export function saveKeypairToFile(keypair: Keypair, relativeFileName: string, dirName: string = DEFAULT_KEY_DIR_NAME) {
+  const fileName = path.join(dirName, `${relativeFileName}.json`);
 
   // create the `dirName` directory, if it does not exists
   if (!fs.existsSync(`./${dirName}/`)) fs.mkdirSync(`./${dirName}/`);

diff --git a/package.json b/package.json
@@ -5,9 +5,9 @@
   "scripts": {
     "sync-package-json": "ts-node scripts/sync-package-json.ts",
     "format:fix": "pnpx @biomejs/biome format --write ./",
-    "lint:fix": "pnpx @biomejs/biome lint --apply ./",
+    "lint:fix": "pnpx @biomejs/biome lint --write ./",
     "lint": "pnpx @biomejs/biome lint ./",
-    "fix": "pnpx @biomejs/biome check --apply ./",
+    "fix": "pnpx @biomejs/biome check --write ./",
     "check": "pnpx @biomejs/biome check ./",
     "prepare": "husky"
   },
@@ -18,7 +18,7 @@
   "author": "Solana Foundation",
   "license": "MIT",
   "devDependencies": {
-    "@biomejs/biome": "1.7.3",
+    "@biomejs/biome": "1.8.1",
     "@types/node": "^20.9.0",
     "husky": "^9.0.11",
     "picocolors": "^1.0.0",