There are so many bugs in the code, is that on purpose so that the developers get a chance to really understand it by fixing the code ?

[kuchaguangjie]

For example, this line:

program-examples/tokens/token-swap/anchor/programs/token-swap/src/instructions/deposit_liquidity.rs

Line 41 in 16068f8

.checked_mul(I64F64::from_num(pool_b.amount))

it should be checked_div(), not checked_mul, right?

[jacobcreech]

@kuchaguangjie it's not meant to have bugs in the code. Any other programs you find problematic? We'll go through them

[kuchaguangjie]

quite some bugs I've found in various sub projects, and to make it work with newest anchor version, almost need always do refactor.

[kuchaguangjie]

Another possible error in the same repo is at:

program-examples/tokens/token-swap/anchor/programs/token-swap/src/instructions/swap_exact_tokens_for_tokens.rs

Line 35 in 16068f8

let output = if swap_a {

According to the code, the formula for output is :

• taxed * b / (a + taxed) when swap_a == true
• taxed * a / (b + taxed) when swap_a == false

That looks doesn't make sense, or does it ?