Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new helper to simplify escrow tests #108

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

mikemaccana
Copy link
Contributor

@mikemaccana mikemaccana commented Jul 26, 2024

We have a new helper that can:

  • Make a bunch of users (with SOL)
  • Make a bunch of tokens
  • Distribute a desired balance of tokens to PDAs for all the users

Use that to make the Escrow program smaller.

Also:

  • replace copy pasted token transfer code with shared transfer_tokens() function
  • fix timing warnings on tests

@mikemaccana mikemaccana force-pushed the use-new-helper-to-simplify-escrow-tests branch 2 times, most recently from 8e8c70b to 10d44f8 Compare July 26, 2024 20:22
@mikemaccana
Copy link
Contributor Author

Test failing, but they work locally and I can't see any errors for the failure on github, Have mentioned to @heyAyushh .

@mikemaccana mikemaccana marked this pull request as ready for review July 29, 2024 18:18
@mikemaccana mikemaccana force-pushed the use-new-helper-to-simplify-escrow-tests branch 2 times, most recently from 5dad6f9 to ae5f91f Compare July 30, 2024 14:02
@mikemaccana mikemaccana force-pushed the use-new-helper-to-simplify-escrow-tests branch from a268b39 to 79570a6 Compare August 9, 2024 15:24
@ZYJLiu ZYJLiu self-requested a review August 9, 2024 17:42
@ZYJLiu ZYJLiu merged commit b992087 into main Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants