Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

++ Poseidon Code Implementation for Counter Program #147

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

++ Poseidon Code Implementation for Counter Program #147

wants to merge 4 commits into from

Conversation

EmekaManuel
Copy link

@EmekaManuel EmekaManuel commented Oct 19, 2024 •
edited
Loading

This Pull Request covers :

  • Poseidon Implementation for Counter Program
  • Complete test coverage with bankrun and chai

@EmekaManuel EmekaManuel changed the title ++ Poseidon Implementation for Counter Program ++ Poseidon Code Implementation for Counter Program Oct 19, 2024
@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. counter basics/counter labels Nov 5, 2024
heyAyushh
heyAyushh reviewed Nov 24, 2024
View reviewed changes
Copy link
Contributor

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyAyushh heyAyushh heyAyushh left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@heyAyushh heyAyushh

@jacobcreech jacobcreech

Labels
contribute:poseidon Adds a poseidon example contribution to the repository. counter basics/counter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmekaManuel @heyAyushh @jacobcreech