-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tokens/spl-token-minter/poseidon #213
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 7554902.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission! To verify the technical implementation, please complete these steps:
- Merge the main branch into your PR to get the latest updates
- Run
pnpm fix
at the project root for consistent code style - Ensure your implementation includes:
- Transpiled Anchor program in the
programs
folder - TypeScript files in the
ts-programs
folder
- Transpiled Anchor program in the
- Run
poseidon sync
to synchronize program ID and keys - Run
cargo fmt
andcargo clippy
for Rust code quality - Push your changes
Please note: This review is to verify technical completeness of the submission
Let me know once you've completed these steps and I'll review again. Thanks!
Thank you for your time on reviewing my code! I would like to notify you that I've completed the aforementioned steps and wish to proceed with another review. Thanks! |
Minor errors with mapping from Poseidon to Rust
Manual imported required for cargo.toml
anchor-spl/idl-build
to idl-build listManual import required for anchor_spl
Missing mutable inside account
#[account()]
--> #[account(mut)] for:to_account
&mint_account
under generatedMintContext