Add basics/realloc/steel #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyAyushh
added
contribute:steel
heyAyushh
reviewed
Dec 1, 2024
There was a problem hiding this comment.
@Perelyn-sama LGTM, would be awesome if it had solana-bankrun tests as well.
Make sure to merge main branch again, run cargo clippy and cargo fmt,
lmk when you push changes.
|
alright, can you please see #189 (comment) |
I just noticed the checks pass now, thanks to this #331 Thanks Ayushh |
heyAyushh
approved these changes
Jan 2, 2025
|
@thewuhxyz 's implementation of realloc is way better. Can we revert this one and merge his? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.