Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to run on localnet #98

Closed
wants to merge 7 commits into from
Closed

Updated to run on localnet #98

wants to merge 7 commits into from

Conversation

ASCorreia
Copy link
Contributor

No description provided.

jacobcreech
jacobcreech reviewed Jul 16, 2024
View reviewed changes
tokens/nft-minter/anchor/tests/test.ts
@@ -25,7 +25,7 @@ describe('NFT Minter', () => {

const transactionSignature = await program.methods
.mintNft(metadata.name, metadata.symbol, metadata.uri)
.accounts({
.accountsPartial({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because of anchor 0.30.x's pda auto resolution?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Added just to be explicit, in the example, on the account to pass in the instruction

@heyAyushh
Copy link
Contributor

some of those programs are missing pnpm-lock.yaml in tests and hence are failing.

For fix, make sure to install packages using https://pnpm.io/ and commit the yaml file 🫡

More in contributing guidelines
https://github.com/solana-developers/program-examples/blob/main/CONTRIBUTING.md#contributing-code-examples

@ASCorreia
Copy link
Contributor Author

some of those programs are missing pnpm-lock.yaml in tests and hence are failing.

For fix, make sure to install packages using https://pnpm.io/ and commit the yaml file 🫡

More in contributing guidelines https://github.com/solana-developers/program-examples/blob/main/CONTRIBUTING.md#contributing-code-examples

The programs already contained a pnpm-lock.yaml that is now up to date with package.json

@ASCorreia ASCorreia closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobcreech jacobcreech jacobcreech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASCorreia @heyAyushh @jacobcreech