Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #678

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix: typos #678

merged 3 commits into from
Jan 8, 2025

Conversation

yash251
Copy link
Contributor

@yash251 yash251 commented Dec 26, 2024

Problem

typos across repo

Summary of Changes

corrected every typo in the repo

@yash251 yash251 requested a review from ZYJLiu as a code owner December 26, 2024 11:42
@yash251
Copy link
Contributor Author

yash251 commented Dec 27, 2024

can you take a look @nickfrosty

@yash251
Copy link
Contributor Author

yash251 commented Jan 8, 2025

following up here @nickfrosty

@yash251
Copy link
Contributor Author

yash251 commented Jan 8, 2025

Thanks for the fix @nickfrosty
when i ran prettier it gave me that all code styles match the prettier but still failed, curious as to what did you run for this?

Copy link
Collaborator

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this @yash251! And thanks for all these typo fixes. I ran the prettier formatting and committed to your branch so we can now merge this :)

@nickfrosty nickfrosty merged commit 1779003 into solana-foundation:main Jan 8, 2025
2 checks passed
@nickfrosty
Copy link
Collaborator

@yash251 I ran pnpm prettier:fix

@yash251
Copy link
Contributor Author

yash251 commented Jan 8, 2025

yep i did the same, not sure why it didn't catch your change
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants