js: Add top-level package.json and turbo build #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging early to see how the dependabot run goes tomorrow morning, please feel free to still give feedback! |
2501babe
reviewed
Nov 16, 2023
Comment on lines
-24
to
+29
| "lint": "yarn pretty && eslint --max-warnings 0 'src/*.ts'", | ||
| "lint:fix": "yarn pretty:fix && eslint 'src/*.ts' --fix", | ||
| "lint": "npm run pretty && eslint --max-warnings 0 'src/*.ts'", | ||
| "lint:fix": "npm run pretty:fix && eslint 'src/*.ts' --fix", | ||
| "pretty": "prettier --check '{src/*.ts,test/*/*.ts}'", | ||
| "pretty:fix": "prettier --write '{src/*.ts,test/*/*.ts}'", | ||
| "doc": "yarn typedoc src/index.ts", | ||
| "test": "yarn test:unit && yarn test:e2e", | ||
| "doc": "npm run typedoc src/index.ts", | ||
| "test": "npm run test:unit && npm run test:e2e", |
There was a problem hiding this comment.
why the change to npm instead of either pnpm or leaving it as-is?
There was a problem hiding this comment.
pnpm fails if yarn is mentioned in the scripts, but works with npm. Since the other packages use npm when calling other scripts, I decided for consistency. We could certainly change it to pnpm though!
|
turbo is surprisingly straightforward |
|
Yeah it's really neat. The default build doesn't figure out inter-package dependencies within your workspace, and just tries to build everything all at once. Apparently turbo will parse everything out and build intelligently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's no top-level
package.json, which means that dependabot doesn't know how to handle the sub-packages in the SPL repo.Solution
Add a top-level package.json! This follows a very similar model to https://github.com/solana-labs/solana-web3.js/blob/master/package.json, and also adds turbo for building, which means that we don't need to declare the dependencies by hand in the CI scripts, which is awesome.
It's still a little messy, but it should be much better to work with overall. The next step might be to isolate all of the JS testing and have them all build their required programs themselves, rather than waiting on the
cargo-test-sbfstep to build it for them. That should greatly reduce the CI time.