[token-cli] Fix panicking behavior from sign_only
#7527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In clap v2, the
ArgMatches::is_present(ARG_NAME)
function returnsNone
whenARG_NAME
is not defined in the clap app. In clap v3,ArgMatches::is_present(ARG_NAME)
panics ofARG_NAME
is not defined in the clap app.I thought I fixed all occurrences of
is_present
that could panic in the token-cli, but it seems that I missed one place when we parse forConfig
.Summary of Changes
Replace
is_present
withtry_contains_id
that does not panic.