Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update avoid_debug_print suggested fix #166

Open
illia-romanenko opened this issue Apr 22, 2024 · 1 comment
Open

Update avoid_debug_print suggested fix #166

illia-romanenko opened this issue Apr 22, 2024 · 1 comment
Assignees
@solid-vovabeloded

Comments

@illia-romanenko
Copy link
Collaborator

See here more: flutter/flutter#147141
We might want just to provide our own utility to do logging?
Or provide better example that just makes sure that debugPrint is guarded by kDebugMode?
@solid-vovabeloded
Copy link
Collaborator

So, basically, we should check that the debugPrint call is wrapped into the !kReleaseMode check, otherwise, we should show the warning.
Also, we should update the lint name to be avoid_debug_print_in_release

@solid-vovabeloded solid-vovabeloded self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solid-vovabeloded solid-vovabeloded

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@illia-romanenko @solid-vovabeloded