Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Content]: The middleware page says that you can chain middleware but does not show how. #757

Open
ian-pascoe opened this issue May 30, 2024 · 1 comment · May be fixed by #1010
Open

[Content]: The middleware page says that you can chain middleware but does not show how. #757

ian-pascoe opened this issue May 30, 2024 · 1 comment · May be fixed by #1010
Labels
good first issue Good for newcomers planned Features or content that are planned but not yet in progress. solidstart Related to SolidStart

Comments

@ian-pascoe
Copy link

ian-pascoe commented May 30, 2024 •
edited
Loading

📚 Subject area/topic

Middleware

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/solid-start/advanced/middleware

📋 Description of content that is out-of-date or incorrect

The page states that you can chain middleware but does not show how or provide an example. There also is no reference for the createMiddleware() function

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response
@ian-pascoe ian-pascoe added improve documentation pending review Awaiting review by team members. labels May 30, 2024
@atilafassina
Copy link
Member

It also doesn't show onResponse middlewares.
This is a low-hanging fruit we should fix ASAP.

Thanks for pointing it out!

@atilafassina atilafassina added good first issue Good for newcomers planned Features or content that are planned but not yet in progress. and removed pending review Awaiting review by team members. labels Sep 1, 2024
@LadyBluenotes LadyBluenotes added solidstart Related to SolidStart and removed improve documentation labels Sep 26, 2024
@amirhhashemi amirhhashemi linked a pull request Jan 9, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers planned Features or content that are planned but not yet in progress. solidstart Related to SolidStart
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update middleware docs amirhhashemi/solid-docs-next
4 participants
@atilafassina @danieljcafonso @LadyBluenotes @ian-pascoe