Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TailwindCSS docs to Tailwind 4.0 #1059

Open
Danvictorgithub opened this issue Feb 5, 2025 · 2 comments · May be fixed by #1065
Open

Fix TailwindCSS docs to Tailwind 4.0 #1059

Danvictorgithub opened this issue Feb 5, 2025 · 2 comments · May be fixed by #1065
Assignees
@Danvictorgithub
Labels
wait to merge

Comments

@Danvictorgithub
Copy link

📚 Subject area/topic

/guides/styling-components/tailwind.mdx

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/guides/styling-components/tailwind

📋 Description of content that is out-of-date or incorrect

The current documentation in the tailwind section, is "outdated"(implemented in Tailwind 3.0). The new installation process of tailwind (now 4.0) no longer uses npx tailwind init -p, instead they are now allowing it directly configuring on css.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response
@Danvictorgithub Danvictorgithub added the pending review Awaiting review by team members. label Feb 5, 2025
@Danvictorgithub
Copy link
Author

I would like to add that, although tailwind released 4.0, I think there should be an opt in for 3.0 (providing tailwindcss@3), reason being is that ui components like the unofficial shadcn for solidjs is still supporting 3.0 and also because shadcn haven't migrated to the latest version of tailwind

@amirhhashemi
Copy link
Collaborator

amirhhashemi commented Feb 6, 2025 •
edited
Loading

I agree. I think the best approach is to:

  1. Keep the current v3 docs. Maybe rename the title and the URL slug to make it explicit this is for the old version of Tailwind. For example, change the title to "TailwindCSS v3" and the URL slug to "tailwind-v3"
  2. Add a guide for v4 and make it the default.
  3. Add a small note in the v4 docs that links to the v3 docs if the user wants to use the old version.

@Danvictorgithub Feel free to send a PR :)

@amirhhashemi amirhhashemi added help wanted Looking for assistance on this issue and removed pending review Awaiting review by team members. labels Feb 7, 2025
@Danvictorgithub Danvictorgithub linked a pull request Feb 8, 2025 that will close this issue
Open
2 tasks
@amirhhashemi amirhhashemi added wait to merge and removed help wanted Looking for assistance on this issue labels Feb 9, 2025
@LadyBluenotes LadyBluenotes added in progress Someone is currently working on the issue. and removed wait to merge labels Feb 13, 2025
@amirhhashemi amirhhashemi added wait to merge and removed in progress Someone is currently working on the issue. labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danvictorgithub Danvictorgithub

Labels
wait to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Tailwind Docs to Tailwind v4 Danvictorgithub/solid-docs
3 participants
@amirhhashemi @Danvictorgithub @LadyBluenotes