From 1f0226e1b669154bc6d53e4619dcae4f3792ce8b Mon Sep 17 00:00:00 2001 From: Ryan Carniato Date: Wed, 18 Oct 2023 00:54:59 -0700 Subject: [PATCH] fix #1917 - hydration error during streaming --- .changeset/long-swans-bow.md | 5 +++++ packages/solid/src/render/Suspense.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/long-swans-bow.md diff --git a/.changeset/long-swans-bow.md b/.changeset/long-swans-bow.md new file mode 100644 index 000000000..60e799be7 --- /dev/null +++ b/.changeset/long-swans-bow.md @@ -0,0 +1,5 @@ +--- +"solid-js": patch +--- + +fix #1917 for real this time diff --git a/packages/solid/src/render/Suspense.ts b/packages/solid/src/render/Suspense.ts index c26e2e751..35883243a 100644 --- a/packages/solid/src/render/Suspense.ts +++ b/packages/solid/src/render/Suspense.ts @@ -144,7 +144,7 @@ export function Suspense(props: { fallback?: JSX.Element; children: JSX.Element if (sharedConfig.context && sharedConfig.load) { const key = sharedConfig.context.id + sharedConfig.context.count; let ref = sharedConfig.load(key); - if (ref && (typeof ref !== "object" || !("value" in ref))) p = ref; + if (ref && (typeof ref !== "object" || ref.status !== "success")) p = ref; if (p && p !== "$$f") { const [s, set] = createSignal(undefined, { equals: false }); flicker = s;