From 292aba41c5b2479bf5c99c70894b57a9734d4299 Mon Sep 17 00:00:00 2001
From: Ryan Carniato <ryansolid@gmail.com>
Date: Wed, 3 Jan 2024 12:57:56 -0800
Subject: [PATCH] fix #1982 ErrorBoundary with ExternalSource

---
 .changeset/moody-spiders-do.md        | 5 +++++
 packages/solid/src/reactive/signal.ts | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/moody-spiders-do.md

diff --git a/.changeset/moody-spiders-do.md b/.changeset/moody-spiders-do.md
new file mode 100644
index 000000000..5828aa227
--- /dev/null
+++ b/.changeset/moody-spiders-do.md
@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+fix #1982 ErrorBoundary with ExternalSource
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
index d8c57b504..cc9251e52 100644
--- a/packages/solid/src/reactive/signal.ts
+++ b/packages/solid/src/reactive/signal.ts
@@ -1428,7 +1428,7 @@ function createComputation<Next, Init = unknown>(
 
   if ("_SOLID_DEV_" && options && options.name) c.name = options.name;
 
-  if (ExternalSourceFactory) {
+  if (ExternalSourceFactory && c.fn) {
     const [track, trigger] = createSignal<void>(undefined, { equals: false });
     const ordinary = ExternalSourceFactory(c.fn, trigger);
     onCleanup(() => ordinary.dispose());