Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single word names are duplicated during PayPal transactions #145

Open
RyanofWoods opened this issue May 30, 2023 · 1 comment
Open

Single word names are duplicated during PayPal transactions #145

RyanofWoods opened this issue May 30, 2023 · 1 comment
Labels

Comments

@RyanofWoods
Copy link
Contributor

RyanofWoods commented May 30, 2023

Current behavior
Single names entered in the Solidus shipping address form become duplicated with a space between during PayPal transactions. (I have not checked Venmo or CreditCard). This seems due to paypal_button.js logic when sending a request to TransactionsController.

Screenshot 2023-05-30 at 07 52 50

Expected behavior
A single name should not be modified by the time of completion.

To Reproduce
Ensure you have PayPal enabled.

  1. On the shipping stage, add only one word to the name field, such as John to the billing address.
  2. Use the billing address for the shipping address.
  3. Continue to checkout using PayPal.

The name will have become John John.

Solidus Version:
Using main at v4.1.0.dev / 474877aaad9139a0a9b8564a9e7279e5446bc12c (bin/sandbox).

Additional context
The shipping address is entered in Solidus, sent to PayPal, then sent back to Solidus (this logic has been quite problematic).

Solidus changed from using firstname and lastname to name, to be more inclusive of countries where only one name is used. This bug defeats the purpose of that.

@tvdeyen
Copy link
Member

tvdeyen commented Jun 25, 2024

Now that we merged https://github.com/solidusio/solidus_braintree/pull/160/files into main, do you mind to test again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants