Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem versioning #116

Open
rbngzlv opened this issue Mar 8, 2018 · 0 comments
Open

Gem versioning #116

rbngzlv opened this issue Mar 8, 2018 · 0 comments

Comments

@rbngzlv
Copy link
Contributor

rbngzlv commented Mar 8, 2018

I have doubts about the versioning / synchronization with core that uses this gem.

If we take as example the tag v1.2.0, it have the following line in their gemspec:

s.add_runtime_dependency 'solidus_core', ['>= 1.1', '< 3']

I'm not sure that this is correct. We can check this key as example:

spree.promotion_rule_types
  • This key is not present in es.yml file, but is present in another locale files.
  • This key is renamed in core since 2.3 version

Perhaps, we need to keep a set of branches in sync with core releases? Or use a external tool to stay in sync with the core changes and manage the translations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant