Skip to content

Commit

Permalink
Switch Tilt image pull policy to IfNotPresent (#10279)
Browse files Browse the repository at this point in the history
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
  • Loading branch information
ryanrolds and soloio-bulldozer[bot] authored Nov 5, 2024
1 parent 3ec73a6 commit 284422b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ RUN chmod 777 ./$binary_name
standard_entrypoint = "ENTRYPOINT /app/start.sh /app/$binary_name"
debug_entrypoint = "ENTRYPOINT /app/start.sh /go/bin/dlv --listen=0.0.0.0:$debug_port --api-version=2 --headless=true --only-same-user=false --accept-multiclient --check-go-version=false exec --continue /app/$binary_name"

get_resources_cmd = "{0} -n {1} template {2} --include-crds install/helm/gloo/ --set gloo.deployment.image.pullPolicy='Always' --set license_key='abcd'".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
get_resources_cmd = "{0} -n {1} template {2} --include-crds install/helm/gloo/ --set gloo.deployment.image.pullPolicy='IfNotPresent' --set license_key='abcd'".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
for f in settings.get("helm_values_files") :
get_resources_cmd = get_resources_cmd + " --values=" + f
get_resources_cmd = get_resources_cmd + " --set=gloo.deployment.livenessProbeEnabled=false"
Expand Down Expand Up @@ -197,7 +197,7 @@ def install_gloo():
if not gloo_installed :
install_helm_cmd = """
kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || {{ kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.1.0/standard-install.yaml; }} ;
{0} upgrade --install -n {1} --create-namespace {2} install/helm/gloo/ --set gloo.deployment.image.pullPolicy='Always' --set license_key='$GLOO_LICENSE_KEY' --set gloo.deployment.glooContainerSecurityContext.readOnlyRootFilesystem=false""".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
{0} upgrade --install -n {1} --create-namespace {2} install/helm/gloo/ --set gloo.deployment.image.pullPolicy='IfNotPresent' --set license_key='$GLOO_LICENSE_KEY' --set gloo.deployment.glooContainerSecurityContext.readOnlyRootFilesystem=false""".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"))
for f in settings.get("helm_values_files") :
install_helm_cmd = install_helm_cmd + " --values=" + f
install_helm_cmd = install_helm_cmd + " --set=gloo.deployment.livenessProbeEnabled=false"
Expand Down
3 changes: 3 additions & 0 deletions changelog/v1.18.0-beta32/tilt-pull-policy-if-not-present.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changelog:
- type: NON_USER_FACING
description: Adjusted pull policy in Tiltfile to `IfNotPresent`. Addresses issue with images being not found in local dev.

0 comments on commit 284422b

Please sign in to comment.