diff --git a/changelog/v1.18.0-beta35/helm-doc-gen.yaml b/changelog/v1.18.0-beta35/helm-doc-gen.yaml new file mode 100644 index 00000000000..4b97b85471d --- /dev/null +++ b/changelog/v1.18.0-beta35/helm-doc-gen.yaml @@ -0,0 +1,6 @@ +changelog: + - type: NON_USER_FACING + issueLink: https://github.com/solo-io/solo-projects/issues/6888 + resolvesIssue: false + description: >- + Update helm public docs generation to work from main branch and only pull in released changes diff --git a/docs/cmd/generate_docs.go b/docs/cmd/generate_docs.go index 0a5a61cd0d3..f0936f7de64 100644 --- a/docs/cmd/generate_docs.go +++ b/docs/cmd/generate_docs.go @@ -454,11 +454,9 @@ func fetchEnterpriseHelmValues(_ []string) error { if err != nil { return err } - version, err := semver.NewVersion(string(semverReleaseTag)) - if err != nil { - return err - } - minorReleaseTag := fmt.Sprintf("v%d.%d.x", version.Major(), version.Minor()) + + minorReleaseTag := "v" + string(semverReleaseTag) + files, err := githubutils.GetFilesFromGit(ctx, client, repoOwner, glooEnterpriseRepo, minorReleaseTag, path) if err != nil { return err diff --git a/pkg/github-action-utils/version.go b/pkg/github-action-utils/version.go index 167cbb7fe35..25189901f8e 100644 --- a/pkg/github-action-utils/version.go +++ b/pkg/github-action-utils/version.go @@ -35,7 +35,9 @@ func GetLatestEnterpriseVersion(repoRootPath string, repo string, owner string) return err } defer f.Close() - enterpriseVersion, err := version.GetLatestHelmChartVersionWithMaxVersion(version.EnterpriseHelmRepoIndex, version.GlooEE, true, maxGlooEVersion) + // get the latest version from the helm repo, include unstable versions so it works from the main branches + // for LTS branches, unstable versions will be filtered out by the version constraints + enterpriseVersion, err := version.GetLatestHelmChartVersionWithMaxVersion(version.EnterpriseHelmRepoIndex, version.GlooEE, false, maxGlooEVersion) if err != nil { return err }