Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator #10365

Closed
sheidkamp opened this issue Nov 18, 2024 · 8 comments
Assignees

Comments

@sheidkamp
Copy link

Which tests failed?

TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator

E2e nightlies:
https://github.com/solo-io/gloo/actions/runs/11886116108/job/33116812397

Error from server: error when creating "/home/runner/work/gloo/gloo/test/kubernetes/e2e/features/tracing/testdata/tracing.yaml": admission webhook "gloo.gloo-gateway-edge-test.svc" denied the request: resource incompatible with current Gloo snapshot: [Validating *v1.Gateway failed: 1 error occurred:
	* Validating *v1.Gateway failed: validating *v1.Gateway name:"gateway-proxy-tracing" namespace:"gloo-gateway-edge-test": 1 error occurred:
	* failed to validate Proxy [namespace: gloo-gateway-edge-test, name: gateway-proxy] with gloo validation: HttpListener Error: ProcessingError. Reason: *v1.Upstream { default.opentelemetry-collector } not found

Initial Investigation

No response

Additional Information

No response

@jenshu
Copy link

jenshu commented Nov 18, 2024

@sheidkamp
Copy link
Author

@sheidkamp
Copy link
Author

#10363 should have fixed this (though it wasn't broken in OSS)

@sheidkamp
Copy link
Author

Passed locally:

--- PASS: TestGlooGatewayEdgeGateway (171.25s)
    --- PASS: TestGlooGatewayEdgeGateway/Tracing (73.02s)
        --- PASS: TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator (18.46s)
PASS

@sheidkamp
Copy link
Author

Seeing

=== NAME  TestGlooGatewayEdgeGateway/Tracing/TestSpanNameTransformationsWithoutRouteDecorator
    testing.go:1577: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

in the logs, so no longer the namespace issue and likely related to #10364

@sheidkamp
Copy link
Author

But saw it with no timeout happening: https://github.com/solo-io/gloo/actions/runs/11927066435/job/33241873159 main nightlies.

Error from server: error when creating "/home/runner/work/gloo/gloo/test/kubernetes/e2e/features/validation/testdata/transformation/vs-transform-header-text.yaml": admission webhook "gloo.full-envoy-validation-test.svc" denied the request: resource incompatible with current Gloo snapshot: [Validating *v1.VirtualService failed: 1 error occurred:
	* Validating *v1.VirtualService failed: validating *v1.VirtualService name:"example-vs" namespace:"full-envoy-validation-test": 1 error occurred:
	* failed gloo validation resource reports: 2 errors occurred:
	* invalid resource full-envoy-validation-test.gateway-proxy
	* envoy validation mode output: error initializing configuration '': Failed to parse response template: Failed to parse

It looks like the fix for this should have been picked up

@sam-heilbron
Copy link

Duplicate issue: k8sgateway#10327

@sam-heilbron
Copy link

With the merging of #10409, I expect this flake to not longer occur on the main (1.18) branch. There is still an underlying bug that is referenced in the code: k8sgateway#10293. I am marking this issue as closed as I expect the flake to not occur. If we see that this fails on the solo-io/gloo@main branch, then we should re-open this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants