Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up-port fix for hardcoded namespace in tracing test #10363

Conversation

ashishb-solo
Copy link

@ashishb-solo ashishb-solo commented Nov 18, 2024

Description

This is an up-port of #10359 onto master

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7223

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7223

@ashishb-solo ashishb-solo marked this pull request as draft November 18, 2024 14:38
@ashishb-solo ashishb-solo marked this pull request as ready for review November 18, 2024 15:02
@nfuden nfuden added the bug Something isn't working label Nov 18, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 3f99c52 into solo-io:main Nov 18, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants