Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition to fido2 1.0.0 and higher #157

Open
vladak opened this issue Jun 23, 2022 Discussed in #156 · 9 comments
Open

transition to fido2 1.0.0 and higher #157

vladak opened this issue Jun 23, 2022 Discussed in #156 · 9 comments

Comments

@vladak
Copy link

vladak commented Jun 23, 2022

Discussed in #156

Originally posted by vladak June 23, 2022
solo1-cli version 0.1.1 (with changes matching PR #153), and brand new Solokey with updated firmware:

$ solo1 ls
:: Solos
None: SoloKeys Solo 4.1.5

and it is not possible to change the default PIN:

$ solo1 key change-pin
Please enter old pin: 
Please enter new pin: 
Please confirm new pin: 
'Fido2Client' object has no attribute 'client_pin'

$ solo1 key set-pin
Please enter new pin: 
Please confirm new pin: 
'Fido2Client' object has no attribute 'client_pin'

I installed the solo1 via the usual means (Python venv + pip install).

The fido2 package is at version 1.0.0.

@vladak vladak changed the title cannot set pin using solo1 due to "'Fido2Client' object has no attribute 'client_pin'" transition to fido2 1.0.0 and higher Jun 23, 2022
@vladak
Copy link
Author

vladak commented Jun 23, 2022

This is not the only problem with using fido2 1.0.0 (see the related discussion), so I changed the bug synopsis.

@AlexNigl
Copy link

AlexNigl commented Aug 5, 2022

A quick fix would be to pin the fido2 version to 0.9.x see #159
This would fix the currently broken "pip install solo1" installation.

@prusnak
Copy link

prusnak commented Oct 18, 2022

Possible fixes in trustcrypto@7e570dc (files solo/devices/base.py, solo/devices/solo_v1.py, solo/solotool.py)

@mcepl
Copy link

mcepl commented Jul 29, 2023

Possible fixes in trustcrypto@7e570dc (files solo/devices/base.py, solo/devices/solo_v1.py, solo/solotool.py)

There are not, this is just a subset of #159 and pretty poorly done (removing some files and adding some others without a reason).

@innir
Copy link
Contributor

innir commented Oct 14, 2023

@nickray @kms15 any update on the fido2 >= 1.0 transition. Debian would like to get fido2 1.1 in and solo1-cli is currently blocking.

@innir
Copy link
Contributor

innir commented Oct 17, 2023

I started working on this now in PR #169 - it's very much WIP. Please test & report breakages as I don't really have an idea how to systematically test ...

@innir
Copy link
Contributor

innir commented Dec 7, 2023

@nickray If you don't act now, this will kick solo1-cli out of Debian, Ubuntu and all their downstream distros unfortunately.

@fabaff
Copy link

fabaff commented May 24, 2024

...will kick solo1-cli out of Debian, Ubuntu and all their downstream distros unfortunately.

The same applies for NIxpkgs.

@innir
Copy link
Contributor

innir commented May 24, 2024

@fabaff You could use PR #169. This version is in Debian testing for six months now without bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants