Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Macros fail if python sources aren't in the initial $workdir #52

Open
DataDrake opened this issue Apr 8, 2018 · 0 comments
Open

Comments

@DataDrake
Copy link
Contributor

Example: Protobuf

The python bindings for protobuf are in a subdirectory named python if you use the current python macros from inside of that directory, install won't work because setup copies up a level, not to $PKG_BUILD_DIR/py{2,3}build

Proposed Solution:

  1. $workdir should be determined before the Setup phase and remain unchanged for the remainder of execution. This eliminates the need for $PKG_BUILD_DIR/.workdir
  2. %python{,3}_setup should copy the current directory to $PKG_BUILD_DIR/py{2,3}build, move to that directory for normal setup, and then return to the previous directory (likely stored in an environment variable)
  3. %python{,3}_install should move to $PKG_BUILD_DIR/py{2,3}build for normal install and then return to the previous directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant