Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap3 and tags dependencies #65

Closed
davedx opened this issue Jan 27, 2014 · 1 comment
Closed

Fix bootstrap3 and tags dependencies #65

davedx opened this issue Jan 27, 2014 · 1 comment
Labels

Comments

@davedx
Copy link
Member

davedx commented Jan 27, 2014

It seems like there's still some stuff to be done with these two packages :)

Tonight I was trying to get spiderable working and discovered I needed the phantomjs mrt package. Unfortunately, doing any adding/removing etc. with mrt at the moment will break the project, because mrt will get the bootstrap3 package from atmosphere instead of the fork at github/solvers (likewise with tags), as it seems to resolve github repos from atmosphere, not from the smart.lock.

So, I've asked the meteor-tags guys if they'd accept our changes as a PR - then we can re-add tags as a normal mrt package.

apendua/meteor-tags#11

For the bootstrap3 package I've locally copied everything out of packages and into client/lib -- this seems to work (I've not committed this yet) -- does this approach sound OK? Because they look very different to each other. :)

@davedx
Copy link
Member Author

davedx commented Feb 7, 2014

I think I've fixed this. Going to let it settle before I close the issue.

@davedx davedx closed this as completed Feb 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants