Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in a random value seed to cluster initialization functions #18

Open
tessbianchi opened this issue Jul 23, 2020 · 3 comments
Open

Comments

@tessbianchi
Copy link

I'm using this library in a context where I need the results to be deterministic. Would it be possible to provide the option to pass a seed into the cluster initialization functions?

I was thinking an optional argument could be passed into the skmeans function called seed and that would be passed on to the kmpp and kmrand .

I am able to implement this functionality, I just want to make sure that this is behavior that library owners want.

Thanks!

@tessbianchi
Copy link
Author

Actually looking a little more closely, I think we would have to allow a full random number generator into the skmeans function, not just the seed.

@solzimer
Copy link
Owner

Hi @tessbianchi
If you want to implement it, go for it! Make a pull request and I'll merge it into the master branch 👍

@tessbianchi
Copy link
Author

Woot! Thanks! I will get started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants