Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we enhance version with git revision #222

Open
sam57719 opened this issue Aug 14, 2024 · 4 comments
Open

Should we enhance version with git revision #222

sam57719 opened this issue Aug 14, 2024 · 4 comments
Labels
Discussion 🔮 enhancement New feature or request 💡 idea Possible ideas for the future ❔ question Further information is requested
Milestone

Comments

@sam57719
Copy link
Collaborator

sam57719 commented Aug 14, 2024

https://pypi.org/project/poetry-git-version-plugin/

This is only in the code and won't affect the git releases

Means we can tell exactly what version we are running on the main smib easily, especially when we run changes before they are part of a release. Might make it easier to big fix.

The get_version() function in smib can return full version with git hash
And create a new get_short_version() to return the current format.

@sjefferson99

@sam57719 sam57719 added Discussion ❔ question Further information is requested 💡 idea Possible ideas for the future 🔮 enhancement New feature or request labels Aug 14, 2024
@sam57719
Copy link
Collaborator Author

@sam57719
Copy link
Collaborator Author

@sjefferson99
Copy link
Member

@sam57719 That is a lot of documentation about getting a version number, which I don't think I can find exciting enough to read through for. What is the actual proposed code change?

@sam57719
Copy link
Collaborator Author

Not sure of the code changes as of yet, but thinking of adding the git revision (local version number), which follows PEP440 standards.

Means that when we run code that's not in a release, we can easily see what version is running exactly to pinpoint problems

@sam57719 sam57719 added this to the SMIB v2.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion 🔮 enhancement New feature or request 💡 idea Possible ideas for the future ❔ question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants