Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main module from tensorflow.rb to tensorflow, keep class-name as Tensorflow (lowercase f) #21

Open
zverok opened this issue Jul 18, 2016 · 6 comments
Milestone

Comments

@zverok
Copy link

zverok commented Jul 18, 2016

I believe it should be TensorFlow (with corresponding gem change to tensor_flow). Current version is not looking too reasonable.

@geoffreylitt
Copy link
Contributor

I would agree with changing capitalization to TensorFlow. That's how it's written on the website, so I think that's least surprising to a new developer trying to remember usage.

However, given that the Python module is called tensorflow, I would personally support keeping the gem name like that. I also think tensorflow is more attractive than tensor_flow.

@zverok
Copy link
Author

zverok commented Jul 19, 2016

@geoffreylitt In fact, nobody will punish us for any solution, but in Ruby there is pretty strong agreement to have correspondence between gem name, main file name, and main gem namespace, so it is expected to either be gem tensorflow/require 'tensorflow'/module Tensorflow or gem tensor_flow, require 'tensor_flow/module TensorFlow.

@chrhansen
Copy link
Collaborator

If you ask me I'd also prefer the most simple, lowercase one word, tensorflow, and loose the .rb ending. Also, in general, I think we should stay as close to the naming and API of the python module as possible, unless it conflicts with Ruby conventions.

I would prefer to see module TensorFlow (T and F capitalized), but would rather stick with require 'tensorflow' and module Tensorflow to follow ruby conventions.

@zverok
Copy link
Author

zverok commented Jul 20, 2016

OK, then let's make the most reasonable thing: tensorflow gem name/main file name and TensorFlow module name. I agree all other options are quite ugly.

@nethsix
Copy link
Collaborator

nethsix commented Jul 26, 2016

I prefer tensorflow, just to be consistent with the python module, and Tensorflow just to be consisten with tensorflow (otherwise there may be confusion).

@jtoy
Copy link
Collaborator

jtoy commented Aug 9, 2016

agree tensorflow is best

@chrhansen chrhansen added this to the 0.1.0 milestone Aug 28, 2016
@chrhansen chrhansen changed the title Rename main module Rename main module from tensorflow.rb to tensorflow, keep class-name as Tensorflow (lower-case f) Aug 28, 2016
@chrhansen chrhansen changed the title Rename main module from tensorflow.rb to tensorflow, keep class-name as Tensorflow (lower-case f) Rename main module from tensorflow.rb to tensorflow, keep class-name as Tensorflow (lowercase f) Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants