Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate defaults #11

Open
nickbhat opened this issue Nov 12, 2020 · 0 comments
Open

Deduplicate defaults #11

nickbhat opened this issue Nov 12, 2020 · 0 comments

Comments

@nickbhat
Copy link
Collaborator

One hyperparameter has multiple defaults set all over the place, resulting in error-prone manual matching.

For example, num_repeats for RepeatDataset has a default in the add_args method of RepeatDataset and a default in the constructor of MSADataModule. This happens in all models as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickbhat