Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting statements for the configuration entities removal in the DASH design considerations #283

Open
aputriax opened this issue Nov 14, 2022 · 0 comments

Comments

@aputriax
Copy link
Collaborator

aputriax commented Nov 14, 2022

DASH HLD design consideration contains the following statements:

11. During VNET or ENI delete, implementation must support ability to delete all mappings or routes in a single API call.
12. Add and Delete APIs are idempotent. As an example, deleting an object that doesn't exists shall not return an error.
13. During a delete operation, if there is a dependency (E.g. mappings still present when a VNET is deleted), implementation shall return error and shall not perform any force-deletions or delete dependencies implicitly.

Looks like 11 conflicts with 13. Should we allow deletion of ENI if mappings exist or return SAI_STATUS_OBJECT_IN_USE?

FYI: BMv2 allows deletion of ENI in this case but then it does not conform with requirement 12 since it fails on the additional deletion attempt.

@aputriax aputriax changed the title Conflicting statement in delete design consideration: Conflicting statement in delete design consideration Nov 14, 2022
@aputriax aputriax changed the title Conflicting statement in delete design consideration Conflicting statements for the configuration entities removal in the DASH design considerations Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant