Add function to retrieve docker0 ipv4 and ipv6 addresses #15606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suvarna Meenakshi <[email protected]>
qiluo-msft
reviewed
Jun 27, 2023
| @@ -484,3 +485,26 @@ def get_asic_presence_list(): | |||
| # asic is asid id: asic0, asic1.... asicN. Get the numeric value. | |||
| asics_list.append(int(get_asic_id_from_name(asic))) | |||
| return asics_list | |||
|
|
|||
| def get_docker0_ip(): | |||
qiluo-msft
reviewed
Jun 27, 2023
| docker0_v6 = None | ||
|
|
||
| # return (None, None) for single asic platform | ||
| if not is_multi_asic(): |
There was a problem hiding this comment.
This helper function is added so that we could use this to get docker0 ip for multi-asic platform.
Most likely we will need docker0 information only for multi-asic platform.
For example, we want to update SNMP_AGENT_ADDRESS_CONFIG table in config_db with docker0 and mgmt IP in miniraph parser and we could avoid adding the single/multi-asic in minigraph parser if we ensure that required IP is passed from this helped function.
Signed-off-by: Suvarna Meenakshi <[email protected]>
10 tasks
Signed-off-by: Suvarna Meenakshi <[email protected]>
|
Do not plan to use this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
#15487 this PR modifies snmpd to listen on specific IPs.
By default, snmpd will listen on management and loopback0 ipv4 and ipv6 addresses for single asic platform.
snmpd will listen will listen on management and docker0 ip address for multi asic platforn.
This PR is to add function to retrieve docker0 ip addresses for multi-asic platform, which could be used generically.
Work item tracking
How I did it
Add a new function get_docker0_ip() in sonic_py_common to get docker0 ipv4 and ipv6 address on multi-asic platform.
How to verify it
on multi-asic platform
on single-asic platform
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)