From 12caaa820dc9c9d5d9038a5648bb6ef8c4b46f77 Mon Sep 17 00:00:00 2001 From: "Austin (Thang Pham)" Date: Wed, 11 Dec 2024 12:04:50 +1100 Subject: [PATCH] chore: toggle plt_reboot_ctrl_overwrite to increase timeout for t2 (#15951) Description of PR Summary: Fixes # (issue) 3045798 The decision was to enable this test gap in #13476 however we mentioned that we need to increase the time. By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300 https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133 For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly. This PR will fix that Approach What is the motivation for this PR? How did you do it? Enable plt_reboot_ctrl_overwrite if platform is T2 Signed-off-by: Austin Pham --- tests/platform_tests/test_reload_config.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/platform_tests/test_reload_config.py b/tests/platform_tests/test_reload_config.py index 1beed69b2d3..cd7e12371de 100644 --- a/tests/platform_tests/test_reload_config.py +++ b/tests/platform_tests/test_reload_config.py @@ -70,7 +70,7 @@ def test_reload_configuration(duthosts, enum_rand_one_per_hwsku_hostname, logging.info("Wait some time for all the transceivers to be detected") max_wait_time_for_transceivers = 300 - if duthost.facts["platform"] == "x86_64-cel_e1031-r0": + if duthost.facts["platform"] in ["x86_64-cel_e1031-r0", "x86_64-88_lc0_36fh_m-r0"]: max_wait_time_for_transceivers = 900 assert wait_until(max_wait_time_for_transceivers, 20, 0, check_all_interface_information, duthost, interfaces, xcvr_skip_list), "Not all transceivers are detected \ @@ -158,7 +158,12 @@ def test_reload_configuration_checks(duthosts, enum_rand_one_per_hwsku_hostname, if not config_force_option_supported(duthost): return + timeout = None + if duthost.get_facts().get("modular_chassis"): + timeout = 420 + reboot(duthost, localhost, reboot_type="cold", wait=5, + timeout=timeout, plt_reboot_ctrl_overwrite=False) # Check if all database containers have started